Throw error if reverse-sync needed, but not allowed #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relrod
reviewed
Sep 25, 2024
ansible_base/resource_registry/utils/sync_to_resource_server.py
Outdated
Show resolved
Hide resolved
|
Comments:
Beyond that, this LGTM. |
AlanCoding
added
the
Ready for review
fosterseth
approved these changes
Oct 7, 2024
AlanCoding
added
blocked
|
I identified a conflict with awx-operator, and probably more. This would probably break things, and our viable path forward may be to go back to Alt 1 out of necessity. |
AlanCoding
changed the title
Thow an error if shared fields are edited with local management turned off Fix grammar error Co-authored-by: Rick Elrod <[email protected]> Add test and change to ValidationError Disconnect signals to fix failure
AlanCoding
force-pushed
the
sync_error
branch
from
62fcdb9
to
345c36e
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a re-do of #618 that attempts to answer the question "what if someone runs
awx-manage createsuperusermanually?"If that command is ran with explicit disabling of reverse-sync, then it will be allowed. It will be confusing that doing this is still permitted even through local_resource_management is off.
But what's the most wrong is to have
The argument is that this configuration is so dangerously contradictory that we should throw an error so that we can front-load debugging of the situation.